Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pipeline by finding another generated form #27429

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 6, 2023

We had found an expression that the cjs-module-lexer would accept, but the esbuild pass we run during packaging destroys that form.

Find another form that also works and is preserved by esbuild.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We had found an expression that the `cjs-module-lexer` would accept,
but the `esbuild` pass we run during packaging destroys that form.

Find another form that also works and is preserved by `esbuild`.
@rix0rrr rix0rrr requested a review from a team October 6, 2023 09:43
@aws-cdk-automation aws-cdk-automation requested a review from a team October 6, 2023 09:43
@github-actions github-actions bot added the p2 label Oct 6, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 6, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 6, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6cbccf6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c48caac into main Oct 6, 2023
14 checks passed
@mergify mergify bot deleted the huijbers/other-form branch October 6, 2023 12:11
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants