Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): delete alpha module #27441

Merged
merged 2 commits into from
Oct 9, 2023
Merged

chore(synthetics): delete alpha module #27441

merged 2 commits into from
Oct 9, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Oct 6, 2023

#27394 added back the synthetics module for CDK release v2.100.0 due to an issue with the peer dependencies that has since been fixed. Since synthetics is stabilized, the alpha module can be safely deleted now.

I downloaded @aws-cdk/aws-synthetics-alpha version 2.100.0-alpha.0 and confirmed that its package.json included the correct peer dependencies with the caret:

  "peerDependencies": {
    "aws-cdk-lib": "^2.100.0",
    "constructs": "^10.0.0"
  },

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 6, 2023 22:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 6, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 9, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f4710aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c9d852a into main Oct 9, 2023
14 checks passed
@mergify mergify bot deleted the conroy/delsynforreal branch October 9, 2023 14:44
kaizencc added a commit that referenced this pull request Oct 9, 2023
mergify bot pushed a commit that referenced this pull request Oct 9, 2023
Reverts #27441

...

snip snap snip snap snip

We will be publishing one last version that deprecates the module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants