Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): naming collisions when using ec2.InitFile.fromAsset() on multiple instances in the same stack #27468

Merged
merged 17 commits into from
Oct 23, 2023
Merged

fix(ec2): naming collisions when using ec2.InitFile.fromAsset() on multiple instances in the same stack #27468

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b9a7e9f
add first test case from issue repro code
sumupitchayan Oct 6, 2023
c30f22b
add md5hash(bindOptions.scope.node.id) to s3 asset name, but test is …
sumupitchayan Oct 9, 2023
c19797a
change bind id hash to hash of md5hash(bindOptions.scope.node.childre…
sumupitchayan Oct 9, 2023
9ec3c62
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 9, 2023
f0fbafd
write initial integ test and create snapshots
sumupitchayan Oct 9, 2023
1d3077a
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 10, 2023
9d61abd
update integ test to use two different testConfigFiles
sumupitchayan Oct 10, 2023
ffff9c3
update integ snapshots
sumupitchayan Oct 10, 2023
530b23a
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 10, 2023
8f55c58
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 10, 2023
a0a2c0a
add comment explaining why the children hash is used
sumupitchayan Oct 11, 2023
956cc54
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 11, 2023
15276b7
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 11, 2023
ae90224
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 12, 2023
f7e98af
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 16, 2023
ed7e007
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
sumupitchayan Oct 16, 2023
bc6d73c
Merge branch 'main' into sumughan/fix-initfiles-with-same-filename
mikewrighton Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ltiple.js.snapshot/asset.04c44be8722f4360fe0830af22298ad0870480310d7bd6eedbbd2391aecf59a8
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

147 changes: 147 additions & 0 deletions .../asset.1be0bac6581864b510bdbf0a114f1d3429244758da7657cc365f73d371fe70ed/__entrypoint__.js
View file
Open in desktop

Large diffs are not rendered by default.

95 changes: 95 additions & 0 deletions ....snapshot/asset.1be0bac6581864b510bdbf0a114f1d3429244758da7657cc365f73d371fe70ed/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...ltiple.js.snapshot/asset.b9ca21e9930115b91ab7e6877bec3bc97b410a6d41fd58816b56aba6db2643bd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...esting/framework-integ/test/aws-ec2/test/integ.instance-init-multiple.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions ...nstance-init-multiple.js.snapshot/instancetestDefaultTestDeployAssert5516EAF1.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ...tance-init-multiple.js.snapshot/instancetestDefaultTestDeployAssert5516EAF1.template.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 58 additions & 0 deletions ...nteg.instance-init-multiple.js.snapshot/integ-ec2-multiple-instances-in-stack.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading