Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticloadbalancingv2-targets): update AlbTarget constructor to accept interface IApplicationLo… #27488

Closed
wants to merge 2 commits into from

Conversation

SarthakPaneru
Copy link
Contributor

…adBalancer (#27466)

I changed the constructor as discussed in the issue

Describe the reason for this change, what the solution is, and any
important design decisions you made.

Remember to follow the CONTRIBUTING GUIDE and DESIGN GUIDELINES for any
code you submit.

Closes#27466.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 11, 2023 02:11
@github-actions github-actions bot added the p2 label Oct 11, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@SarthakPaneru SarthakPaneru changed the title feat(aws-elasticloadbalancingv2-targets): update AlbTarget constructor to accept interface IApplicationLo… feat(elasticloadbalancingv2-targets): update AlbTarget constructor to accept interface IApplicationLo… Oct 11, 2023
@SarthakPaneru
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 11, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 918aa80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 11, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@vinayak-kukreja vinayak-kukreja self-assigned this Oct 11, 2023
@vinayak-kukreja
Copy link
Contributor

Exemption Request

Hey could you tell me why this needs to be exempted?

@vinayak-kukreja
Copy link
Contributor

I do not believe this needs to be a feat. Could you align the title as per conventional commits?

@vinayak-kukreja
Copy link
Contributor

Could you also update the PR body formatting? It looks like it has part of the title and is not descriptive :)

@vinayak-kukreja
Copy link
Contributor

We will also not able to accept a PR from main branch on your fork. Could you follow steps here and make this contribution from another branch on your fork?

@SarthakPaneru
Copy link
Contributor Author

I have created new PR #27516 @vinayak-kukreja, will you look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants