-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glue-alpha): adding partition projection #27490
Closed
Closed
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dde68dd
Adding Partition Projection
guyernest aca83ff
Merge branch 'main' into main
guyernest 7082ecc
Merge branch 'main' into main
guyernest 5922652
Adding integration test for partition projection
guyernest 070ac51
Merge branch 'main' of https://github.com/guyernest/aws-cdk
guyernest 8374d0c
Merge branch 'main' into main
guyernest 42a72a9
Cleaning tests from unused variable
guyernest 26a18eb
Merge branch 'main' into partition-projection
guyernest c822b1b
Merge branch 'main' into partition-projection
guyernest eff2a4e
Merge branch 'main' into partition-projection
guyernest 31f63bd
Merge branch 'main' into partition-projection
guyernest 625df89
Merge branch 'main' into partition-projection
guyernest 1e34a63
Linting
guyernest e63eaa6
Adding docstring to public elements
guyernest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 135 additions & 0 deletions
135
packages/@aws-cdk/aws-glue-alpha/lib/partition-projection.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
/* | ||
* @see https://docs.aws.amazon.com/athena/latest/ug/partition-projection-supported-types.html#partition-projection-date-type | ||
*/ | ||
export enum PartitionProjectionType { | ||
ENUM_TYPE = 'enum', | ||
INTEGER_TYPE = 'integer', | ||
DATE_TYPE = 'date', | ||
INJECTED_TYPE = 'injected', | ||
} | ||
|
||
/* | ||
* Dynamic Partition Projection Class | ||
* | ||
* @see https://docs.aws.amazon.com/athena/latest/ug/partition-projection.html | ||
* | ||
*/ | ||
export abstract class PartitionProjection { | ||
constructor( | ||
public readonly type: PartitionProjectionType, | ||
public readonly columnName: string, | ||
public readonly storageLocationTemplate: string) {} | ||
|
||
public getParameterKey(paramName: string): string { | ||
return `${this.columnName}.${paramName}`; | ||
} | ||
public toOutputFormat(): any { | ||
throw new Error('Method not implemented.'); | ||
} | ||
} | ||
|
||
/* | ||
* @see https://docs.aws.amazon.com/athena/latest/ug/partition-projection-supported-types.html#partition-projection-date-type | ||
* A time unit word that represents the serialized form of a ChronoUnit. | ||
* Possible values are YEARS, MONTHS, WEEKS, DAYS, HOURS, MINUTES, SECONDS, or MILLISECONDS. These values are case insensitive. | ||
*/ | ||
export enum DateIntervalUnit { | ||
YEARS = 'YEARS', | ||
MONTHS = 'MONTHS', | ||
WEEKS = 'WEEKS', | ||
DAYS = 'DAYS', | ||
HOURS = 'HOURS', | ||
MINUTES = 'MINUTES', | ||
SECONDS = 'SECONDS', | ||
MILLISECONDS = 'MILLISECONDS', | ||
} | ||
|
||
export class DatePartitionProjection extends PartitionProjection { | ||
constructor( | ||
public readonly columnName: string, | ||
public readonly storageLocationTemplate: string, | ||
public readonly range: string, | ||
public readonly format: string, | ||
public readonly interval?: number, | ||
public readonly intervalUnit?: DateIntervalUnit, | ||
) { | ||
super( | ||
PartitionProjectionType.DATE_TYPE, | ||
columnName, | ||
storageLocationTemplate); | ||
} | ||
|
||
toOutputFormat(): any { | ||
const baseKey = `projection.${this.columnName}`; | ||
return { | ||
['projection.enabled']: true, | ||
['storage.location.template']: this.storageLocationTemplate, | ||
[`${baseKey}.type`]: this.type, | ||
[`${baseKey}.format`]: this.format, | ||
[`${baseKey}.range`]: this.range, | ||
[`${baseKey}.interval`]: this.interval ? String(this.interval) : undefined, | ||
[`${baseKey}.interval.unit`]: this.intervalUnit ? this.intervalUnit : undefined, | ||
}; | ||
} | ||
} | ||
|
||
export class IntegerPartitionProjection extends PartitionProjection { | ||
constructor( | ||
public readonly columnName: string, | ||
public readonly storageLocationTemplate: string, | ||
public readonly range: string, | ||
public readonly interval?: number, | ||
public readonly digits?: number) { | ||
super( | ||
PartitionProjectionType.INTEGER_TYPE, | ||
columnName, | ||
storageLocationTemplate); | ||
} | ||
|
||
toOutputFormat(): any { | ||
const baseKey = `projection.${this.columnName}`; | ||
return { | ||
['projection.enabled']: true, | ||
['storage.location.template']: this.storageLocationTemplate, | ||
[`${baseKey}.type`]: this.type, | ||
[`${baseKey}.range`]: this.range, | ||
[`${baseKey}.interval`]: this.interval ? String(this.interval) : undefined, | ||
[`${baseKey}.digits`]: this.digits ? String(this.digits) : undefined, | ||
}; | ||
} | ||
|
||
} | ||
export class EnumPartitionProjection extends PartitionProjection { | ||
constructor( | ||
public readonly columnName: string, | ||
public readonly storageLocationTemplate: string, | ||
public readonly values: string) { | ||
super( | ||
PartitionProjectionType.ENUM_TYPE, | ||
columnName, | ||
storageLocationTemplate, | ||
); | ||
} | ||
|
||
toOutputFormat(): any { | ||
const baseKey = `projection.${this.columnName}`; | ||
return { | ||
['projection.enabled']: true, | ||
['storage.location.template']: this.storageLocationTemplate, | ||
[`${baseKey}.type`]: this.type, | ||
[`${baseKey}.values`]: this.values, | ||
}; | ||
} | ||
|
||
} | ||
|
||
export class InjectedPartitionProjection extends PartitionProjection { | ||
constructor( | ||
public readonly columnName: string, | ||
public readonly storageLocationTemplate: string) { | ||
super( | ||
PartitionProjectionType.INJECTED_TYPE, | ||
columnName, | ||
storageLocationTemplate); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @guyernest I see the following error,
I am curious, are you seeing these fail in PR builds or local builds too?