-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): added support for EKS version 1.28 #27502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
@khushail was there an eta for this? Would be interested in contributing if possible. |
I assume this PR depends on that: cdklabs/awscdk-asset-kubectl#450 |
@endersonmaia ,your assumption is correct. |
cdklabs/awscdk-asset-kubectl#450 it's merged! |
@khushail Can you fix the PR please |
Is there anything else blocking this? Would be great to get 1.28 support in CDK for those of us needing to migrate away from soon-to-be deprecated versions |
Exemption Request |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
If you don't want to be blocked on this you can use |
@khushail can you figure out how to get the build to succeed? Looks like maybe the import statements might be incorrect? |
Sure, I will take a look. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Similar to this (#25897), added support for EKS 1.28
Resolves (#27500)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license