feat(lambda): add grantInvokeCompositePrincipal method #27529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
admired-contributor
msambol
commented
Oct 13, 2023
msambol
force-pushed
the
composite-principals
branch
from
89754b1 to
b4b4f18
Compare
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Oct 13, 2023
packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.permissions.ts
Show resolved
Hide resolved
|
@lpizzinidev Updated per your feedback—thanks! |
aws-cdk-automation
added
pr/needs-maintainer-review
vinayak-kukreja
previously requested changes
Oct 18, 2023
There was a problem hiding this comment.
Hey @msambol , this is great. Thank you for opening this PR with us.
I just have some NITs and please let me know if the integ tests are dry-run and I can run these for you.
...work-integ/test/aws-lambda/test/integ.permissions.js.snapshot/lambda-permissions.assets.json
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-cloudfront/lib/experimental/edge-function.ts
Outdated
Show resolved
Hide resolved
aws-cdk-automation
removed
the
pr/needs-maintainer-review
msambol
force-pushed
the
composite-principals
branch
from
0ad557f to
914daa5
Compare
mergify
bot
dismissed
vinayak-kukreja’s stale review
Pull request has been modified.
aws-cdk-automation
added
the
pr/needs-maintainer-review
vinayak-kukreja
approved these changes
Oct 19, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to grant function access to
CompositePrincipal.Closes #27503.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license