-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: auto close pr if opened from fork's main branch #27627
Conversation
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
tools/@aws-cdk/prlint/lint.ts
Outdated
// Closing the PR if it is opened from main branch of author's fork | ||
if (failureMessages.includes(PR_FROM_MAIN_ERROR)) { | ||
|
||
const errorMessageBody = 'We are unable to accept contributions from `main` branch of a fork. This pull request would be automatically closed now. Please open a new pull request from another branch on your fork. For more information, see https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in case there are multiple linter errors. This would clarify to the author why we are closing the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rico wants something more in line with https://github.com/aws/aws-cdk/pull/27625/files which is why he made that update. Can we just repeat the words there in the closing message?
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR would enable closing a pull request automatically if it is opened from
main
branch of their fork.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license