Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoscaling): AutoScalingGroup.requireImdsv2 throws error with LaunchTemplates #27648

Merged
merged 6 commits into from
Oct 26, 2023
Merged

fix(autoscaling): AutoScalingGroup.requireImdsv2 throws error with LaunchTemplates #27648

merged 6 commits into from
Oct 26, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Oct 23, 2023 •
edited
Loading

This PR fixes the bug that AutoScalingGroup.requireImdsv2 throws error with LaunchTemplates.

This handles LaunchTemplate in AutoScalingGroupRequireImdsv2Aspect when a feature flag AUTOSCALING_GENERATE_LAUNCH_TEMPLATE is true.

Closes #27586.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 23, 2023 12:05
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Oct 23, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k go-to-k marked this pull request as ready for review October 23, 2023 13:55
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 23, 2023 13:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 23, 2023
scanlonp
scanlonp previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to use an escape hatch to set the metadataOptions on the L1 so that it is not undefined. The validation is follows the same lines as what we had before; looks great! Excellent tests!
Thanks!

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k
Copy link
Contributor Author

go-to-k commented Oct 26, 2023 •
edited
Loading

@scanlonp

Thanks!

But the Queue: Embarked in merge queue with a following message displays and the merge fails, could you please handle this?

This pull request cannot be embarked for merge
The merge queue pull request can't be updated
Details:

Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@mergify mergify bot dismissed scanlonp’s stale review October 26, 2023 14:05

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f8b46ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a4142aa into aws:main Oct 26, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
mrgrain pushed a commit that referenced this pull request Nov 1, 2023
@go-to-k @mrgrain
fix(autoscaling): AutoScalingGroup.requireImdsv2 throws error with La…
9926139 
…unchTemplates (#27648)

This PR fixes the bug that AutoScalingGroup.requireImdsv2 throws error with LaunchTemplates.

This handles `LaunchTemplate` in `AutoScalingGroupRequireImdsv2Aspect` when a feature flag `AUTOSCALING_GENERATE_LAUNCH_TEMPLATE` is true.

Closes #27586.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@go-to-k go-to-k deleted the fix/AutoScalingGroup-LaunchTemplates-aspect branch November 7, 2023 08:15
@rahman rahman mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-autoscaling): AutoScalingGroup.requireImdsv2 throws error with LaunchTemplates
3 participants
@go-to-k @aws-cdk-automation @scanlonp