Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): Add support for P5 instances EC2 #27705

Merged
merged 8 commits into from
Nov 2, 2023
Merged

feat(ec2): Add support for P5 instances EC2 #27705

merged 8 commits into from
Nov 2, 2023

Conversation

niroam
Copy link
Contributor

@niroam niroam commented Oct 26, 2023

The P5 instance types were introduced in July 2023.
The instance types are supported in CloudFormation.

Closes #27704.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 26, 2023 23:37
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Oct 26, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@niroam niroam changed the title Add support for P5 instances feat(ec2): Add support for P5 instances EC2 Oct 26, 2023
@niroam
Copy link
Contributor Author

niroam commented Oct 26, 2023

Exemption Request: This PR is similar to #27611, which didn't need changes to the README and tests.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 26, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 27, 2023
@niroam
Copy link
Contributor Author

niroam commented Oct 27, 2023

Exemption Request: This PR is similar to #27611, which didn't need changes to the README and tests.

Please add tags pr-linter/exempt-readme and pr-linter/exempt-integ-test

scanlonp
scanlonp previously requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Fix this typo and we are good to go.

packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 27, 2023
@scanlonp scanlonp added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Oct 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 27, 2023 15:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@niroam @scanlonp
Fix comments to match
4d634b2 
Co-authored-by: Parker Scanlon <69879391+scanlonp@users.noreply.github.com>
@mergify mergify bot dismissed scanlonp’s stale review October 29, 2023 02:20

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 29, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
scanlonp
scanlonp previously approved these changes Nov 2, 2023
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 2, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed scanlonp’s stale review November 2, 2023 01:05

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 2, 2023
@scanlonp
Copy link
Contributor

scanlonp commented Nov 2, 2023

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 2, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6b86647
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c3357ad into aws:main Nov 2, 2023
8 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_ec2: Support for P5 InstanceClass
3 participants
@niroam @scanlonp @aws-cdk-automation