-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ses): create unit tests for drop spam handler #27769
Conversation
Signed-off-by: Francis <colifran@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with DNM just for my little refactor if you want it, not a hard requirement.
test('drop spam when spf verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ spf: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('drop spam when dkim verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ dkim: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('drop spam when spam verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ spam: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('drop spam when virus verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ virus: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test('drop spam when spf verdict status is FAIL', async () => { | |
const sesEvent = createSesEvent({ spf: { status: 'FAIL' } }); | |
const response = await handler(sesEvent); | |
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | |
}); | |
test('drop spam when dkim verdict status is FAIL', async () => { | |
const sesEvent = createSesEvent({ dkim: { status: 'FAIL' } }); | |
const response = await handler(sesEvent); | |
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | |
}); | |
test('drop spam when spam verdict status is FAIL', async () => { | |
const sesEvent = createSesEvent({ spam: { status: 'FAIL' } }); | |
const response = await handler(sesEvent); | |
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | |
}); | |
test('drop spam when virus verdict status is FAIL', async () => { | |
const sesEvent = createSesEvent({ virus: { status: 'FAIL' } }); | |
const response = await handler(sesEvent); | |
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | |
}); | |
test.each([ 'spf', 'dkim', 'spam', 'virus'])('drop spam when %s status is FAIL', (key) => { | |
const sesEvent = createSesEvent({ [key]: { status: 'FAIL' } }); | |
const response = await handler(sesEvent); | |
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | |
}); |
Just nitpicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Updated.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds unit tests for the SES drop spam handler. Specifically, the unit tests verify that spam will be dropped under the following conditions:
FAIL
FAIL
FAIL
FAIL
An additional unit test was added to ensure that null is returned if all the above verdicts are not
FAIL
.Closes #27726
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license