chore: add L1 example to lakeformation readme #27917
Conversation
| resourceName: 'Admin', | ||
| }), | ||
| }, | ||
| { dataLakePrincipalIdentifier: `arn:aws:iam::${accountId}:role/cdk-hnb659fds-cfn-exec-role-${accountId}-${region}` }, |
There was a problem hiding this comment.
Probably cleaner like this:
{
// The CDK cloudformation execution role.
dataLakePrincipalIdentifier: synthesizer.cloudFormationExecutionRoleArn.replace('${AWS::Partition}', 'aws'),
}
| const accountId = process.env.CDK_DEFAULT_ACCOUNT!; | ||
| const region = process.env.CDK_DEFAULT_REGION!; |
There was a problem hiding this comment.
We can probably remove these and use this.account and this.region everywhere
|
|
||
| ### Example | ||
|
|
||
| Using the lakeformation L1s is not always the most straight forward. Here is an example of creating a glue table and putting lakeformation tags on it. Note: this example uses deprecated constructs and overly permissive IAM roles. This example is meant to give a general idea of using the L1s; it is not production level. |
There was a problem hiding this comment.
Nit: I would remove the first sentence and just start with "Here is an example of creating a glue table and ...". Also should we give an example that isn't using the deprecated glue Table?
vinayak-kukreja
removed
the
pr/do-not-merge
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license