Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore(cdk): boostrap template uses deprecated AccessControl property" #27939

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

colifran
Copy link
Contributor

Reverts #27764

@github-actions github-actions bot added the p2 label Nov 10, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 10, 2023 23:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 10, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@colifran colifran changed the title revert "chore(cdk): boostrap template uses deprecated AccessControl property" revert: "chore(cdk): boostrap template uses deprecated AccessControl property" Nov 11, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 11, 2023 00:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Nov 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eba37c9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 093c4ed into main Nov 11, 2023
8 of 9 checks passed
@mergify mergify bot deleted the revert-27764-patch-4 branch November 11, 2023 01:06
Copy link
Contributor

mergify bot commented Nov 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@scarytom
Copy link
Contributor

@colifran why did my change get reverted?

This AccessControl property is deprecated and is being flagged by cfn-lint

@mrgrain
Copy link
Contributor

mrgrain commented Dec 12, 2023

@colifran why did my change get reverted?

This AccessControl property is deprecated and is being flagged by cfn-lint

See #27964

The bootstrap stack template has been widly reviewed and assessed. If you need to to comply with further requirements, like passing an unconfigured cfn-lint check, I recommend rolling your own custom version of it.

Appreciate you are taking the time the review this from a security perspective though.

@scarytom
Copy link
Contributor

Thanks for the reply.

I had a look at #27964, and I'm really surprised by that. The original pull request was reviewed, and it was agreed that this legacy property doesn't do anything. Seems strange to have a deprecated property that is not actually deprecated.

Thanks for the link to rolling our own template. We already do that, but I like to try and contribute improvement upstream, which was the case here.

@mrgrain
Copy link
Contributor

mrgrain commented Dec 12, 2023

Found this. I don't have all the details, but looks like it might have be an issue with migrating existing buckets with certain account configurations.

#27929

@scarytom
Copy link
Contributor

I guess backwards compatibility with imperfect existing setups is important, so I can understand how we got here, thanks. I guess we live with it, as there is no easy way to make a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants