Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudformation-diff): cdk diff throws toUpperCase is not a function when ipProtocol is a number #28023

Merged
merged 6 commits into from
Nov 21, 2023
Merged

fix(cloudformation-diff): cdk diff throws toUpperCase is not a function when ipProtocol is a number #28023

merged 6 commits into from
Nov 21, 2023

Conversation

gastonsilva
Copy link
Contributor

Fix the describe protocol method when running a diff with a processed existing cloudformation template that has a security group rule with ipprotocol = -1

Closes #28021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 16, 2023 00:42
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Nov 16, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@gastonsilva
Copy link
Contributor Author

Exemption Request
Cannot find a way to implement an integration test for this scenario

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 16, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Nov 17, 2023
@vinayak-kukreja vinayak-kukreja changed the title fix: diff ipprotocol describe fix: cdk diff throws this.ipProtocol.toUpperCase is not a function when ipProtocol is a number Nov 20, 2023
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Nov 20, 2023
@vinayak-kukreja vinayak-kukreja changed the title fix: cdk diff throws this.ipProtocol.toUpperCase is not a function when ipProtocol is a number fix: cdk diff throws toUpperCase is not a function when ipProtocol is a number Nov 20, 2023
@vinayak-kukreja vinayak-kukreja changed the title fix: cdk diff throws toUpperCase is not a function when ipProtocol is a number fix(cloudformation-diff): cdk diff throws toUpperCase is not a function when ipProtocol is a number Nov 20, 2023
@vinayak-kukreja vinayak-kukreja added the pr/do-not-merge This PR should not be merged at this time. label Nov 20, 2023
@vinayak-kukreja
Copy link
Contributor

Hey @gastonsilva , thank you for your contribution.

I am confirming with the team if an exemption could be granted for this PR. Other than that, the changes looks good to me.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2023
@vinayak-kukreja vinayak-kukreja added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 21, 2023 22:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 091bb1d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vinayak-kukreja vinayak-kukreja removed the pr/do-not-merge This PR should not be merged at this time. label Nov 21, 2023
Copy link
Contributor

mergify bot commented Nov 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 182bafc into aws:main Nov 21, 2023
15 of 16 checks passed
@gastonsilva gastonsilva deleted the fix/diff-ipprotocol-describe branch November 22, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk/cloudformation-diff: this.ipProtocol.toUpperCase is not a function
3 participants