-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): add ipv6AllowedForDualStack
for lambda function
#28059
Conversation
Update fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
@Mergifyio update |
☑️ Nothing to do
|
ipv6AllowedForDualStack
prop to lambda functionipv6AllowedForDualStack
to lambda function
ipv6AllowedForDualStack
to lambda functionipv6AllowedForDualStack
for lambda function
@Mergifyio update |
✅ Branch has been successfully updated |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Can you link the issue in the description as |
@mikewrighton there is no specific issue for this cfn coverage gap. I put related to the larger ipv6 issue. |
@@ -14,4 +15,14 @@ new lambda.Function(stack, 'MyLambda', { | |||
vpc, | |||
}); | |||
|
|||
app.synth(); | |||
new lambda.Function(stack, 'IPv6EnabledLambda', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the existing PR and its integration tests were failing, here's my fork with changes to integration tests and almost similar changes for the feature implementation that works: Vandita2020@e2c7753
#28928 adds this functionality. |
This property sets the cloudformation
VpcConfigProperty
property of the same name. This feature will enable Lambda functions to be configured to allow or disallow IPv6 traffic when using dual-stack VPC configurations.Related #894.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license