Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): add ipv6AllowedForDualStack for lambda function #28059

Closed
wants to merge 23 commits into from

Conversation

scanlonp
Copy link
Contributor

@scanlonp scanlonp commented Nov 18, 2023

This property sets the cloudformation VpcConfigProperty property of the same name. This feature will enable Lambda functions to be configured to allow or disallow IPv6 traffic when using dual-stack VPC configurations.

Related #894.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@scanlonp scanlonp added the p1 label Nov 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 18, 2023 01:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@scanlonp
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 18, 2023

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]
  • -conflict [:pushpin: update requirement]

@scanlonp scanlonp changed the title feat(lambda): add ipv6AllowedForDualStack prop to lambda function feat(lambda): add ipv6AllowedForDualStack to lambda function Nov 18, 2023
@scanlonp scanlonp added the pr-linter/exempt-readme The PR linter will not require README changes label Nov 18, 2023
@scanlonp scanlonp changed the title feat(lambda): add ipv6AllowedForDualStack to lambda function feat(lambda): add ipv6AllowedForDualStack for lambda function Nov 20, 2023
@scanlonp scanlonp added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 20, 2023
@scanlonp
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 20, 2023

update

✅ Branch has been successfully updated

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 20, 2023 16:44

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3117a55
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mikewrighton
Copy link
Contributor

mikewrighton commented Nov 20, 2023

Can you link the issue in the description as Fixes #...?

@scanlonp
Copy link
Contributor Author

@mikewrighton there is no specific issue for this cfn coverage gap. I put related to the larger ipv6 issue.

@@ -14,4 +15,14 @@ new lambda.Function(stack, 'MyLambda', {
vpc,
});

app.synth();
new lambda.Function(stack, 'IPv6EnabledLambda', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the existing PR and its integration tests were failing, here's my fork with changes to integration tests and almost similar changes for the feature implementation that works: Vandita2020@e2c7753

@scanlonp
Copy link
Contributor Author

scanlonp commented Mar 7, 2024

#28928 adds this functionality.

@scanlonp scanlonp closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants