-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add support for AccountIdFromAlias #27642 #28180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
(justification for requesting exemption on integration test) The test does not require a stack deployment. cfn-parse is an internal helper class for validating a cloud formation template. Please feel free to suggest. Will appreciate any guidance/suggestion and be happy to adopt them. (need clarification on doc/readme change). Checked this readme file for aws-cdk-lib/core module link. Is this the right file/place to use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks great!
On the exemption, I do not think you need either an integ test or a readme update.
However, I could not find any documentation on the Fn::AccountIdFromAlias cloudformation function. For example it is not here https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference.html. Can you provide some documentation on this function?
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
reason for this change:
Fn::AccountIdFromAlias
. This function can be used in cloud formation templates to reference another account(s) using a conventional alias string. We can get rid of hardcoding AWS account ID(s) in cloud formation templates. So it's helpful for automating region build process.cfn-parse
in theaws-cdk/core
module has not yet added the support for this new CFN function, as a result of which,cfn-parse
would fail to recognize this function as a valid/supported CFN function.fix #27642
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license