Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): use default account/region when environment is not specified #2867

Merged
merged 2 commits into from
Jun 13, 2019
Merged

fix(core): use default account/region when environment is not specified #2867

merged 2 commits into from
Jun 13, 2019

Commits on Jun 13, 2019

  1. fix(core): use default account/region when environment is not specified 

    The PR #2728 caused a regression on how the framework behaves when a
stack's environment (account and/or region) are not specified.

The behavior is: if account and/or region are not specified at the stack
level (or set to Aws.accountId and Aws.region, respectively), the cloud
assembly manifest of this stack will have an environment specification
based on the defaults passed in from the CLI.

This is a temporary solution which fixes #2853 but doesn't fully implement
the behavior we eventually want (which is documented in #2866).
    Elad Ben-Israel committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    eb1b908 View commit details
    Browse the repository at this point in the history

  2. fix linting error

    Elad Ben-Israel committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    effe80f View commit details
    Browse the repository at this point in the history