Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firehose-destinations-alpha): support zero buffering #28716

Merged
merged 3 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export interface CommonDestinationS3Props {
* The length of time that Firehose buffers incoming data before delivering
* it to the S3 bucket.
*
* Minimum: Duration.seconds(60)
* Minimum: Duration.seconds(0)
* Maximum: Duration.seconds(900)
*
* @default Duration.seconds(300)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ export function createBufferingHints(
}

const intervalInSeconds = interval?.toSeconds() ?? 300;
if (intervalInSeconds < 60 || intervalInSeconds > 900) {
throw new Error(`Buffering interval must be between 60 and 900 seconds. Buffering interval provided was ${intervalInSeconds} seconds.`);
if (intervalInSeconds > 900) {
scanlonp marked this conversation as resolved.
Show resolved Hide resolved
throw new Error(`Buffering interval must be less than 900 seconds. Buffering interval provided was ${intervalInSeconds} seconds.`);
}
const sizeInMBs = size?.toMebibytes() ?? 5;
if (sizeInMBs < 1 || sizeInMBs > 128) {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,146 @@
"DependsOn": [
"DeliveryStreamS3DestinationRoleDefaultPolicy3015D8C7"
]
},
"ZeroBufferingDeliveryStreamS3DestinationRole606BB6E3": {
"Type": "AWS::IAM::Role",
"Properties": {
"AssumeRolePolicyDocument": {
"Statement": [
{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Principal": {
"Service": "firehose.amazonaws.com"
}
}
],
"Version": "2012-10-17"
}
}
},
"ZeroBufferingDeliveryStreamS3DestinationRoleDefaultPolicyC03FC12E": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyDocument": {
"Statement": [
{
"Action": [
"s3:Abort*",
"s3:DeleteObject*",
"s3:GetBucket*",
"s3:GetObject*",
"s3:List*",
"s3:PutObject",
"s3:PutObjectLegalHold",
"s3:PutObjectRetention",
"s3:PutObjectTagging",
"s3:PutObjectVersionTagging"
],
"Effect": "Allow",
"Resource": [
{
"Fn::GetAtt": [
"Bucket83908E77",
"Arn"
]
},
{
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"Bucket83908E77",
"Arn"
]
},
"/*"
]
]
}
]
},
{
"Action": [
"logs:CreateLogStream",
"logs:PutLogEvents"
],
"Effect": "Allow",
"Resource": {
"Fn::GetAtt": [
"ZeroBufferingDeliveryStreamLogGroupFA68202E",
"Arn"
]
}
}
],
"Version": "2012-10-17"
},
"PolicyName": "ZeroBufferingDeliveryStreamS3DestinationRoleDefaultPolicyC03FC12E",
"Roles": [
{
"Ref": "ZeroBufferingDeliveryStreamS3DestinationRole606BB6E3"
}
]
}
},
"ZeroBufferingDeliveryStreamLogGroupFA68202E": {
"Type": "AWS::Logs::LogGroup",
"Properties": {
"RetentionInDays": 731
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
},
"ZeroBufferingDeliveryStreamLogGroupS3Destination806CFD96": {
"Type": "AWS::Logs::LogStream",
"Properties": {
"LogGroupName": {
"Ref": "ZeroBufferingDeliveryStreamLogGroupFA68202E"
}
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
},
"ZeroBufferingDeliveryStream7C2555C9": {
"Type": "AWS::KinesisFirehose::DeliveryStream",
"Properties": {
"DeliveryStreamType": "DirectPut",
"ExtendedS3DestinationConfiguration": {
"BucketARN": {
"Fn::GetAtt": [
"Bucket83908E77",
"Arn"
]
},
"BufferingHints": {
"IntervalInSeconds": 0,
"SizeInMBs": 5
},
"CloudWatchLoggingOptions": {
"Enabled": true,
"LogGroupName": {
"Ref": "ZeroBufferingDeliveryStreamLogGroupFA68202E"
},
"LogStreamName": {
"Ref": "ZeroBufferingDeliveryStreamLogGroupS3Destination806CFD96"
}
},
"CompressionFormat": "GZIP",
"ErrorOutputPrefix": "errorPrefix",
"Prefix": "regularPrefix",
"RoleARN": {
"Fn::GetAtt": [
"ZeroBufferingDeliveryStreamS3DestinationRole606BB6E3",
"Arn"
]
}
}
},
"DependsOn": [
"ZeroBufferingDeliveryStreamS3DestinationRoleDefaultPolicyC03FC12E"
]
}
},
"Mappings": {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading