feat(efs): transition to archive for FileSystem
#28719
Conversation
github-actions
bot
added
p2
repeat-contributor
github-actions
bot
added
the
feature-request
aws-cdk-automation
added
the
pr/needs-community-review
…2222/aws-cdk into efs-transition-to-archive
Co-authored-by: Kyle Laker <kyle@laker.email>
… to be more consistent with other policies
longtv2222
force-pushed
the
efs-transition-to-archive
branch
from
eae85fd
to
2e1513c
Compare
There was a problem hiding this comment.
Hi @longtv2222, this looks great to me except for the one comment below. Thanks for contributing!
| /** | ||
| * After 365 days of not being accessed. | ||
| */ | ||
| AFTER_365_DAYS = 'AFTER_365_DAYS', |
There was a problem hiding this comment.
It looks like TransitionToIA and TransitionToArchive have the same set of enums excelt that TransitionToArchive does not allow AFTER_1_DAY source
Can you add in a synth-time check that throws an error if AFTER_1_DAY is set for transitionToArchivePolicy? Plus a unit test :)
There was a problem hiding this comment.
It looks like they share the same set of enums to me. The order is a bit off for AFTER_1_DAY...
Submitted docs feedback for improvement.
From: https://docs.aws.amazon.com/efs/latest/ug/lifecycle-management-efs.html
There was a problem hiding this comment.
I'm also able to create EFS with transitionToArchive set to 1 day as well! (I can update integration test to test AFTER_1_DAY for transitionToArchivePolicy if needed)
There was a problem hiding this comment.
sorry. the order screwed me up and shame on me for expecting the enum list to be in the same chronological order :)
kaizencc
changed the title
FileSystemFileSystem
github-actions
bot
added
the
effort/medium
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds support for
TransitionToArchiveproperty forAWS::EFS::FileSystemAlso updated
LifecyclePolicyto add missing values forTransitionToArchiveandTransitionToIADocs
Closes #28720.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license