Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): custom resources deprecate logRetention in favor of logGroup #28783

Merged
merged 4 commits into from
Jan 22, 2024

Commits on Jan 19, 2024

  1. feat(core): custom resources deprecate logRetention properties in f…

    …avor of `logGroup`
    
    See #28737 for full details.
    
    Some custom resources have made the `logRetention` property part of their own API. In these cases, we are now also deprecating `logRetention`.
    
    Migrating log groups for custom resource would follow the same steps as outline in #28737. Given that custom resource logging is for debugging purposes and there are no guarantees about the output format, it should be possible to simply replace `logRetention` with a simple `logGroup` in most cases:
    
    ```ts
    const awsCustom1 = new cr.AwsCustomResource(this, 'API1', {
      // Replace this
      logRetention: logs.RetentionDays.ONE_WEEK,
      // with
      logGroup: new logs.LogGroup(this, 'AwsCustomResourceLogs', {
        retention: logs.RetentionDays.ONE_WEEK,
      }),
    });
    ```
    mrgrain committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    960d317 View commit details
    Browse the repository at this point in the history
  2. deprecation save assignment

    mrgrain committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b78ad0f View commit details
    Browse the repository at this point in the history
  3. make kaizen happy

    mrgrain committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    106bc14 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    9e11bbd View commit details
    Browse the repository at this point in the history