feat(rds): allocatedStorage parameter for DatabaseInstanceReadReplica #28789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
aws-cdk-automation
added
the
pr/needs-maintainer-review
GavinZZ
reviewed
Jan 23, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
GavinZZ
dismissed
their stale review
Mergify will automatically merge main and merge PR. Let's change the README first.
aws-cdk-automation
added
the
pr/needs-maintainer-review
Co-authored-by: GZ <hz351086153@gmail.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
GavinZZ
approved these changes
Jan 24, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an optional
allocatedStorageparameter to DatabaseInstanceReadReplica. Allows customers to set the AllocatedStorage for their replica instance.Note: Didn't add any synth checks as the original deployment issue outlined in #17083 seems to be fixed (Deployed the failed template and the replica instance will automatically inherit the storage of the source instance). Customers should still be able to set
allocatedStorage.Closes #17083.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license