Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigatewayv2): WebSocketAwsIntegration ignores requestParameters and integrationPassThrough behaviors #28921

Merged
merged 4 commits into from
Jan 30, 2024
Merged

fix(apigatewayv2): WebSocketAwsIntegration ignores requestParameters and integrationPassThrough behaviors #28921

merged 4 commits into from
Jan 30, 2024

Conversation

georgechristman
Copy link
Contributor

#28718 missed adding requestParameters to the WebSocketAwsIntegration. Also added integrationPassThrough behaviors.

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 29, 2024 21:17
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 29, 2024
@GavinZZ GavinZZ self-requested a review January 29, 2024 21:52
@GavinZZ
Copy link
Contributor

GavinZZ commented Jan 29, 2024 •
edited
Loading

For context, this is the same change as #28905, which is closed due to branch issues. Some reviews comment are there.

Changes look good, happy to approve once CI passes.

GavinZZ
GavinZZ approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b969f6d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 990ead3 into aws:main Jan 30, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this pull request Feb 8, 2024
@georgechristman @SankyRed
fix(apigatewayv2): WebSocketAwsIntegration ignores requestParameters …
c459d72 
…and integrationPassThrough behaviors (#28921)

#28718 missed adding requestParameters to the WebSocketAwsIntegration. Also added integrationPassThrough behaviors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgechristman @GavinZZ @aws-cdk-automation