-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ecs): Asset ContainerImage no longer takes Construct arguments #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn the `ContainerImage` into the standard integration pattern. It is no longer a construct itself, but creates subconstructs during `bind`. BREAKING CHANGE: * **ecs**: `ContainerImage.fromAsset()` now takes only build directory directly (no need to pass `scope` or `id` anymore).
rix0rrr
requested review from
RomainMuller,
skinny85,
SoManyHs and
a team
as code owners
June 18, 2019 12:45
eladb
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
rix0rrr
changed the title
refactor(ecs): ContainerImage no longer takes asset arguments
refactor(ecs): Asset ContainerImage no longer takes Construct arguments
Jun 18, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the
ContainerImage
into the standard integration pattern. It isno longer a construct itself, but creates subconstructs during
bind
.BREAKING CHANGE:
ContainerImage.fromAsset()
now takes only build directorydirectly (no need to pass
scope
orid
anymore).Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.