Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecs): Asset ContainerImage no longer takes Construct arguments #2906

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 18, 2019

Turn the ContainerImage into the standard integration pattern. It is
no longer a construct itself, but creates subconstructs during bind.

BREAKING CHANGE:

  • ecs: ContainerImage.fromAsset() now takes only build directory
    directly (no need to pass scope or id anymore).

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Turn the `ContainerImage` into the standard integration pattern. It is
no longer a construct itself, but creates subconstructs during `bind`.

BREAKING CHANGE:

* **ecs**: `ContainerImage.fromAsset()` now takes only build directory
  directly (no need to pass `scope` or `id` anymore).
@rix0rrr rix0rrr requested review from RomainMuller, skinny85, SoManyHs and a team as code owners June 18, 2019 12:45
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rix0rrr rix0rrr changed the title refactor(ecs): ContainerImage no longer takes asset arguments refactor(ecs): Asset ContainerImage no longer takes Construct arguments Jun 18, 2019
@rix0rrr rix0rrr merged commit 8f400e7 into master Jun 18, 2019
@rix0rrr rix0rrr deleted the huijbers/simplify-containerimage branch June 18, 2019 14:59
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants