Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): latest canary runtimes for NodeJS, Python #29132

Merged
merged 7 commits into from
Feb 16, 2024
Merged

feat(synthetics): latest canary runtimes for NodeJS, Python #29132

merged 7 commits into from
Feb 16, 2024

Conversation

wilhen01
Copy link
Contributor

@wilhen01 wilhen01 commented Feb 16, 2024

Closes #29135

Reason for this change

Surface latest runtime versions in CDK. Older runtimes are being deprecated March 19, 2024

To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates.

Description of changes

  • feat(synthetics): add 5.2, 6.1, 6.2 nodejs runtimes, deprecate 3.x runtimes
  • feat(synthetics): add syn-python-selenium-2.1 runtime
  • test(synthetics): update integration tests to cover latest runtimes

Description of how you validated changes

Attempted to run integration tests, but I don't have appropriate account setup

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 16, 2024 10:36
@wilhen01
Copy link
Contributor Author

wilhen01 commented Feb 16, 2024

Two queries for this one:

  1. I've added the @deprecated tag for older Node runtimes. A number of the more recent runtimes will be deprecated in March - should these also be tagged as @deprecated with a note of the date, or should that change only be made once they are actually deprecated?
  2. I've updated the integration tests to cover the latest runtime versions, but it's not an exhaustive list - should it cover every available runtime?

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@npvisual
Copy link

FYI. This is pretty critical since AWS just sent out a note about a planned lifecycle event by March 19, 2024:

To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 16, 2024 15:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@wilhen01
Copy link
Contributor Author

FYI. This is pretty critical since AWS just sent out a note about a planned lifecycle event by March 19, 2024:

To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates.

Yep, that's why I'm raising the PR - we got health alerts in our accounts for the deprecation 👍

@wilhen01
Copy link
Contributor Author

wilhen01 commented Feb 16, 2024

I believe that the integration test snapshot should now be in a good state but I had a certain amount of fun trying to get it there. Someone more familiar should definitely check this over 😅

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6ed62f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud added p1 and removed p2 labels Feb 16, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 16, 2024
@kaizencc kaizencc changed the title feat(synthetics): add latest canary runtimes for NodeJS, Python feat(synthetics): latest canary runtimes for NodeJS, Python Feb 16, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Feb 16, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks for this update @wilhen01

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 16, 2024
Copy link
Contributor

mergify bot commented Feb 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3c122a4 into aws:main Feb 16, 2024
26 checks passed
@wilhen01 wilhen01 deleted the canary-runtimes branch February 16, 2024 16:52
GavinZZ pushed a commit that referenced this pull request Feb 22, 2024
Closes #29135

### Reason for this change

Surface latest runtime versions in CDK. Older runtimes are being deprecated March 19, 2024

> To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates.

### Description of changes

- feat(synthetics): add 5.2, 6.1, 6.2 nodejs runtimes, deprecate 3.x runtimes
- feat(synthetics): add syn-python-selenium-2.1 runtime
- test(synthetics): update integration tests to cover latest runtimes

### Description of how you validated changes

Attempted to run integration tests, but I don't have appropriate account setup

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@msambol
Copy link
Contributor

msambol commented Mar 13, 2024

@wilhen01 I'm late to this but I think you need to mark a few more deprecated. This link shows up to syn-nodejs-puppeteer-6.1 was deprecated on March 8, 2024.

@wilhen01
Copy link
Contributor Author

@msambol those runtimes weren't deprecated when this PR was merged on Feb 22nd. Someone should raise a PR to deprecate them now that we're past the deprecation date - go for it if you have time 😄

@msambol
Copy link
Contributor

msambol commented Mar 13, 2024

Oops! I saw your message in slack and thought it was from today. I'll do another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-synthetics: NodeJS puppeteer Runtime Versions 5.2 & 6.2 & Python Selenium 2.1
6 participants