feat(events): make target optional in onXxx() methods
#2921
Conversation
Make `target` optional in `OnEventOptions` so that it is no required when calling a `onXxx()` method. This allows to use "preconfigured" rules in other constructs. Closes aws#2913
|
|
Okay, so let’s just add a test |
|
It’s fishy that nothing broke at the consumption side when this changes from required to optional. I’d expect some null check... |
There's one already |
https://github.com/awslabs/aws-cdk/blob/83eee09e8198ae1921b932c09a6d14c88392800d/packages/%40aws-cdk/aws-events/test/test.rule.ts is full of rules created without targets, what kind of test do you want to add? something in the An extra test in |
|
Yes sounds good. Just to exercise this specific path |
Options are now not required in `onXxx` methods, but IRepository was not updated to that end. Related #2921
Options are now not required in `onXxx` methods, but IRepository was not updated to that end. Related #2921
Additional fixes like #3036 Options are now not required in onXxx methods, but the interfaces where not updated to that end. Related #2921 Root cause: aws/jsii#548
Make
targetoptional inOnEventOptionsso that it is no required when calling aonXxx()method.
This allows to use "preconfigured" rules in other constructs.
Update
awslint:events-method-signatureto enforce optionaloptionsparameter inonXxx()method signatures.Closes #2913
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.