-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(events_targets): installing latest aws sdk fails in cn partition #29374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
packages/aws-cdk-lib/aws-events-targets/lib/log-group-resource-policy.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/log-group-resource-policy.ts
Outdated
Show resolved
Hide resolved
4ee050f
to
879f6b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29373
Reason for this change
AWS Log Group event target by default installs the latest aws sdk for its custom resource and this would fail in
aws-cn
partition. This PR exposes theinstallLatestAwsSdk
to the surface and allows users to optionally turn offinstallLatestAwsSdk
for cloudwatch log events target.Description of changes
Allow users to override the value, if unset default to true which is the same behaviour as current.
Description of how you validated changes
all tests pass.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license