Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events_targets): installing latest aws sdk fails in cn partition #29374

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Mar 6, 2024

Issue # (if applicable)

Closes #29373

Reason for this change

AWS Log Group event target by default installs the latest aws sdk for its custom resource and this would fail in aws-cn partition. This PR exposes the installLatestAwsSdk to the surface and allows users to optionally turn off installLatestAwsSdk for cloudwatch log events target.

Description of changes

Allow users to override the value, if unset default to true which is the same behaviour as current.

Description of how you validated changes

all tests pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 labels Mar 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 6, 2024 18:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 6, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ GavinZZ marked this pull request as ready for review March 6, 2024 18:03
@GavinZZ GavinZZ added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 6, 2024 18:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ force-pushed the yuanhaoz/cloudwatch_target_sdk_fix branch from 4ee050f to 879f6b1 Compare March 6, 2024 18:33
@github-actions github-actions bot added p1 and removed p2 labels Mar 6, 2024
Copy link
Contributor

@pahud pahud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Mar 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1a5cc88
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f0383d6 into main Mar 6, 2024
15 checks passed
@mergify mergify bot deleted the yuanhaoz/cloudwatch_target_sdk_fix branch March 6, 2024 19:38
Copy link
Contributor

mergify bot commented Mar 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
5 participants