Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): revert incorrect account used for S3 event source mapping #29405

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix(s3): revert incorrect account used for S3 event source mapping #29405

merged 2 commits into from
Mar 7, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Mar 7, 2024

Reverts #29365 as it causes test failure.

@github-actions github-actions bot added the p2 label Mar 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 7, 2024 22:05
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 7, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ GavinZZ marked this pull request as ready for review March 7, 2024 22:07
@GavinZZ GavinZZ changed the title Revert "fix(s3): incorrect account used for S3 event source mapping" fix(s3): revert incorrect account used for S3 event source mapping Mar 7, 2024
@GavinZZ GavinZZ added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 7, 2024 22:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9e0a008
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ba41996 into main Mar 7, 2024
12 checks passed
@mergify mergify bot deleted the revert-29365-s3_account_2 branch March 7, 2024 23:03
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xazhao xazhao xazhao approved these changes

@paulhcsun paulhcsun paulhcsun approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GavinZZ @aws-cdk-automation @paulhcsun @xazhao