feat(route53): allow specifying an STS region when creating a cross-account zone delegation

[naiello]

Issue # (if applicable)

n/a

Reason for this change

In certain circumstances, the default STS region resolution logic will not properly select a region due to the hardcoded mapping between region prefixes and STS regions.

Description of changes

This change allows callers to specify a region in which STS will be called.

Description of how you validated changes

Unit tests were added to aws-cdk-lib. Integ tests were updated and pass on my personal accounts, but I'm not sure how to check if they'll pass in CI.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aaythapa]

Thanks for PR! Left a few comments but nothing major.

Changes look good, could you add README changes and integ tests so the linter is happy? You can use yarn integ --update-on-failed to update the snapshots of existing tests

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[naiello]

Please double-check the integ test changes as this is my first contribution to aws-cdk. The tests are passing on my personal account(s), but I'm not sure how to verify they'll pass properly in the CICD.

[naiello]

Snapshot Results:

Tests:    1 failed, 1 total
Failed: /home/nick/projects/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.cross-account-zone-delegation.js

Running integration tests for failed tests...

Running in parallel across profiles cross-region and regions: us-east-1, us-east-2, us-west-2
Running test /home/nick/projects/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.cross-account-zone-delegation.js in cross-region/us-east-1
  SUCCESS    aws-route53/test/integ.cross-account-zone-delegation-Route53CrossAccountInteg/DefaultTest 535.347s
       NO ASSERTIONS

Test Results:

Tests:    1 passed, 1 total
Done in 536.06s.

[msambol]

LGTM. 👍🏼

[aaythapa]

🚢

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aaythapa]

@Mergifyio update

[mergify]

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: a20148d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).