fix: improve type annotation for CustomResource properties

[jfly]

Issue # (if applicable)

refs aws/aws-cdk-rfcs#375

Reason for this change

My team just went on quite the adventure trying to figure out why JSON false values were getting converted to "false". It would have been really nice if cdk's typing could have prevented that bug in the first place. (It would be even nicer if the underlying CloudFormation bug were fixed, but this is better than nothing)

Description of changes

I've improved the typing of the properties attribute to help people realize that only strings leaves are allowed here.

Description of how you validated changes

I have not tested this, hopefully the change is straightforward enough.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
  • I know this PR currently violates Step 3: Work your Magic
    of the CONTRIBUTING GUIDE as there's no unittest. I don't know what an appropriate unittest would look like here, but I'm happy to add one if you suggest it.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[jfly]

Exemption Request: I don't know what an appropriate unittest would look like here, but I'm happy to add one if you suggest it.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[jfly]

See above, I requested an exception. Again, happy to add unittests if someone points me in a useful direction.

[jfly]

No idea if this is useful, but reposting:

Exemption Request: I don't know what an appropriate unittest would look like here, but I'm happy to add one if you suggest it.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5aa92dd
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[jfly]

This PR is very much not abandonded. I think these two automations are fighting with each other: I requested an exemption, and didn't get feedback before the PR was automatically closed.

@aws-cdk-automation, can I get a human's eyes on this please?

[jfly]

@SankyRed, I see you recently reopened a PR that was closed for staleness. Any advice about what I should do here?

[calebpalmer]

I also went through this adventure and think this could be useful. I hope this PR gets some attention.

[jfly]

@aws-cdk-automation, @SankyRed, any advice about what I should do here?

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.