Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): typos in flagname, make test description accurate #29652

Closed
wants to merge 6 commits into from

Conversation

Smeb
Copy link

@Smeb Smeb commented Mar 29, 2024

Tiny fixup for code documentation - I was using the wrong flag because I took it from the comments on the diff command.

I also changed the description for a test, since it doesn't actually check the flag name.

@github-actions github-actions bot added the p2 label Mar 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 29, 2024 11:47
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 29, 2024
@Smeb Smeb temporarily deployed to test-pipeline March 29, 2024 11:48 — with GitHub Actions Inactive
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Mar 29, 2024
@Smeb Smeb changed the title fix typos in flagname, make test description accurate docs(cli): typos in flagname, make test description accurate Mar 29, 2024
This was referenced Apr 1, 2024
comcalvi
comcalvi previously approved these changes Apr 1, 2024
@comcalvi comcalvi added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Apr 1, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 1, 2024 18:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Apr 1, 2024
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mergify mergify bot dismissed comcalvi’s stale review April 3, 2024 08:42

Pull request has been modified.

@Smeb
Copy link
Author

Smeb commented Apr 3, 2024

Ah shoot - I hit update before reading the comment. Will update to allow upstream commits, sorry for that.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 3, 2024
@scanlonp
Copy link
Contributor

scanlonp commented Apr 4, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 4, 2024

update

✅ Branch has been successfully updated

@mergify mergify bot had a problem deploying to test-pipeline April 4, 2024 21:21 Failure
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@scanlonp scanlonp added the pr-linter/do-not-close The PR linter will not close this PR while this label is present label Apr 11, 2024
comcalvi
comcalvi previously approved these changes May 6, 2024
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 11, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@TheRealAmazonKendra
Copy link
Contributor

I'm not sure what the deal is with all the issues deploying our tests but it's certainly not the content of this PR. Let's see if I can get this merged.

@mergify mergify bot dismissed comcalvi’s stale review June 11, 2024 20:37

Pull request has been modified.

@TheRealAmazonKendra
Copy link
Contributor

Actually, it looks like we've made changes since this PR was originally made and the comment added is no longer relevant. I'm going to go ahead and close this one.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5927452
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/do-not-close The PR linter will not close this PR while this label is present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants