feat(rds): specify PreferredMaintenanceWindow in reader or writer props

[Konosh93]

Issue #29687

Closes ##29687

Reason for this change

Since instanceProps is deprecated it is better to allow setting PreferredMaintenanceWindow using writer and readers props.

Description of changes

Added optional preferredMaintenanceWindow field to ClusterInstanceOptions and added a unit test.

Description of how you validated changes

• Add a single unit test

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[Konosh93]

[IMO] Based on the previous fix, I think this PR also qualifies for an Exemption Request.

#29033 (comment)

[msambol]

Can you change the title to:

"feat(rds): specify PreferredMaintenanceWindow in reader or writer props"

Also, this one should have an integration test. Let me know if you need help with that.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[Konosh93]

Can you change the title to:

"feat(rds): specify PreferredMaintenanceWindow in reader or writer props"

Sure. Thanks. 👍

Also, this one should have an integration test. Let me know if you need help with that.

I modified an existing test in packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.ts.

[msambol]

LGTM

[godwingrs22]

LGTM. Thanks @Konosh93 for your contribution and @msambol for your review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: cb4a440
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.