chore(certificatemanager): improve logging for cert creation #30525
Conversation
github-actions
bot
added
the
beginning-contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -284,7 +284,7 @@ export class Certificate extends CertificateBase implements ICertificate { | |||
|
|
|||
| // check if domain name is 64 characters or less | |||
| if (!Token.isUnresolved(props.domainName) && props.domainName.length > 64) { | |||
| throw new Error('Domain name must be 64 characters or less'); | |||
| throw new Error(`Domain name must be 64 characters or less, got ${props.domainName.length}: ${props.domainName}`); | |||
There was a problem hiding this comment.
This wording is a bit too casual. Could you wordsmith this a bit?
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
Improve log messaging to help with debugging
Description of changes
N/A
Description of how you validated changes
Updated unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license