feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664
Conversation
github-actions
bot
added
the
beginning-contributor
|
hey guys, this is my first contribution to this repo, I would be grateful for any feedback 🤝 |
default configuration of Alias target health check
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
wladyslawczyzewski
changed the title
| /** | ||
| * Evaluate the target health | ||
| * | ||
| * @default - undefined |
There was a problem hiding this comment.
The default value is undefined, but could you describe what settings are applied when it is undefined?
There was a problem hiding this comment.
hi @badmintoncryer , I've changed this to more descriptive information about the default value of this property. Could you please check and let me know what do you think?
packages/aws-cdk-lib/aws-route53-targets/lib/bucket-website-target.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-route53-targets/lib/classic-load-balancer-target.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-route53-targets/lib/elastic-beanstalk-environment-target.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-route53-targets/lib/global-accelerator-target.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-route53-targets/lib/load-balancer-target.ts
Outdated
Show resolved
Hide resolved
| } | ||
| constructor( | ||
| private readonly environmentEndpoint: string, | ||
| private readonly props: ElasticBeanstalkEnvironmentEndpointTargetProps = { evaluateTargetHealth: false }, |
There was a problem hiding this comment.
Could you explain why only the target for Beanstalk has false specified as the default value?
There was a problem hiding this comment.
hi @badmintoncryer , thanks for your review. This change should be reverted in one of previous commits but looks like I missed that. Thanks for catching this!
…rget.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…ncer-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…-environment-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…r-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…get.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
also changed the description on default value of AliastRecordTargetConfig.evaluateTargetHealth
|
hi @badmintoncryer thanks fro your review. I have applied the changes you suggested and added few more integration test cases. Could you please check these changes and let me know your thoughts? |
aws-cdk-automation
removed
the
pr/needs-community-review
|
@wladyslawczyzewski Thank you for your modification. I'll check and approve this PR later. Please wait for a while |
|
@wladyslawczyzewski Could you please add integ test for |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
hi @badmintoncryer I just added the test case for Elastic Beanstalk Environment target, please check it out! |
Issue # (if applicable)
Part of a bigger piece of work for #9481
Another PR for this ticket #30739
Reason for this change
At this moment constructing the Route53 health checks is available only via L1 construct, this PR is one of the series to introduce the R53 health checks via higher-level constructs.
Description of changes
The underlying L1 construct of a few L2 constructs for Alias targets already has the
EvaluateTargetHealthproperty, so by adding this prop to the L2 construct we get the quick win to introduce the health checks for Alias records.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license