Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kinesisanalytics-flink): support for Flink 1.19 runtime #30757

Closed
wants to merge 4 commits into from

Conversation

buddhike
Copy link

@buddhike buddhike commented Jul 5, 2024

No description provided.

@aws-cdk-automation aws-cdk-automation requested a review from a team July 5, 2024 04:37
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 5, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@buddhike buddhike force-pushed the ft/flink-1.19-update branch from 19b7473 to 154dbc2 Compare July 5, 2024 04:52
@buddhike buddhike changed the title Add support for Flink 1.19 runtime feat(kinesisanalytics-flink): support for Flink 1.19 runtime Jul 5, 2024
@buddhike buddhike force-pushed the ft/flink-1.19-update branch from 0ff67ea to daeb300 Compare July 5, 2024 05:20
@buddhike buddhike force-pushed the ft/flink-1.19-update branch from daeb300 to 7c69e94 Compare July 5, 2024 06:53
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 5, 2024 06:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@clementallen
Copy link
Contributor

clementallen commented Jul 5, 2024

Duplicate of #30723?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@buddhike
Copy link
Author

buddhike commented Jul 8, 2024

Duplicate of #30723?

Amazing and thanks for submitting a PR with this change @clementallen 🙏🏾. Yes, this looks like a duplicate. Sorry, I didn't check PRs queue.
I'm going to leave this open until I get a chance to review why there's a difference in the patch.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7d6997d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants