chore(lambda): inline code size limit is 4MB

[msambol]

Issue # (if applicable)

Closes #30761.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[scanlonp]

This seems like a massive in-line code size, but not out of the question.

Looks like there used to be a character restriction on inline code based on some old stackoverflow answers, but that may have been removed.

I would like to see if an inline lambda will deploy with more than 4kb. The template being synthesized is not a good indicator of whether it works or not since it would be a CFN limit that we do not validate currently.

[msambol]

This seems like a massive in-line code size, but not out of the question.

Looks like there used to be a character restriction on inline code based on some old stackoverflow answers, but that may have been removed.

I would like to see if an inline lambda will deploy with more than 4kb. The template being synthesized is not a good indicator of whether it works or not since it would be a CFN limit that we do not validate currently.

I changed it to be the resulting zip file cannot exceed 4MB. I think that's the only limit we can deduce from the docs?

[scanlonp]

Hey @msambol, I am doing some work with lambda assets, so I will give this a spin. I still think this may be an error in their documentation. The limit for a CFN template as a whole uploaded to s3 is 1 MB (CFN limits).

I'd love to be wrong here, but I am feeling lucky with this prediction! I'll get back to you shortly.

[msambol]

@scanlonp Any update on this one?

[msambol]

@scanlonp Thoughts here? Should I close this?

[GavinZZ]

Hello, sorry for the wait. This change LGTM and approved it. Appreciate the contribution.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[msambol]

@mergify update

[mergify]

update

✅ Branch has been successfully updated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (2677fce) to head (6ec558e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30773      +/-   ##
==========================================
- Coverage   78.67%   78.66%   -0.02%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
- Hits         5694     5693       -1     
- Misses       1357     1358       +1     
  Partials      186      186              

Flag	Coverage Δ
suite.unit	78.66% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	78.66% <ø> (-0.02%)	⬇️

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 6ec558e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

• ❌ codecov/project
• ❌ codecov/project/packages/aws-cdk

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.