Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix asset bundling for nested stack with exclusive flag #30983

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jk2l
Copy link

@jk2l jk2l commented Jul 31, 2024

Issue #30967

Closes #30967

Reason for this change

Incorrect bundling required check for child stack return by the function

Description of changes

The current nested stack used parent stack's inherited function which cause incorrect assessment

More details description:

  • Given you have Stage "Stage", root stack "Stack1" and child stack "Stack1Nested". the this.node.path used is Stage/Stack1/StackNested, however the context it validate against is only "Stage/Stack1". the current function do not validate against child stack's stack name. To fix this, i simply have the child stack call the parent stack, and if the root stack is match then all child stack will be marked as bundling required.

Description of how you validated changes

Implemented via test driven approach, validate by test case

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2024 01:22
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jk2l jk2l changed the title Fix(core): Fix asset bundling for nested stack with exclusive flag fix(core): Fix asset bundling for nested stack with exclusive flag Jul 31, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jul 31, 2024
@jk2l
Copy link
Author

jk2l commented Jul 31, 2024

Clarification Request: i have test case implemented, not sure what else is it asking here.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jul 31, 2024
@jk2l jk2l changed the title fix(core): Fix asset bundling for nested stack with exclusive flag fix(core): fix asset bundling for nested stack with exclusive flag Jul 31, 2024
@jk2l jk2l force-pushed the fix/asset-bundling branch from 09b05db to eb9417f Compare July 31, 2024 03:19
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eb9417f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jk2l
Copy link
Author

jk2l commented Jul 31, 2024

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 31, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: Asset bundling ignored when deploy with --exclusive flag with nested stack
2 participants