Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set log retention of all CDK-vended custom resources with CustomResourceConfig #31041

Merged
merged 57 commits into from
Aug 16, 2024
Merged

feat: set log retention of all CDK-vended custom resources with CustomResourceConfig #31041

merged 57 commits into from
Aug 16, 2024

Conversation

awslukeguan
Copy link
Contributor

@awslukeguan awslukeguan commented Aug 6, 2024 •
edited
Loading

Reason for this change

CDK vended custom resources may or may not have Cloudwatch logGroup set with a retention period.
Modify all CDK-vended custom resources with CustomResourceConfig and to modify retention period with addLogRetentionLifetime method.

CustomResourceConfig.of(app).addLogRetentionLifetime(logs.RetentionDays.TEN_YEARS);

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 6, 2024 17:01
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@awslukeguan awslukeguan changed the title chore: Added method addMetadata for singleton lambda construct tree chore: added method addMetadata for singleton lambda construct tree Aug 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 6, 2024 17:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 6, 2024
@comcalvi comcalvi self-requested a review August 6, 2024 18:09
@comcalvi comcalvi self-assigned this Aug 6, 2024
comcalvi
comcalvi previously requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I have a few comments though 🙂

Please add an integration test (in @aws-cdk-testing), move this code to aws-cdk-lib/custom-resources and update that module's README to tell users how to use the new feature.

packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/classes.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/classes.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/classes.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/classes.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/classes.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resource-config/custom-resource-config.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resource-config/test/custom-resource-config.test.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resource-config/test/custom-resource-config.test.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resource-config/test/custom-resource-config.test.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resource-config/test/custom-resource-config.test.ts Outdated Show resolved Hide resolved
@comcalvi
Copy link
Contributor

comcalvi commented Aug 8, 2024

Also please update the title to be a feat, since this is a feature. The feature should describe the new feature you're adding; for example, "Set log retention of all CDK-vended custom resources with CustomResourceConfig"

@mergify mergify bot dismissed comcalvi’s stale review August 8, 2024 21:02

Pull request has been modified.

@awslukeguan awslukeguan changed the title chore: added method addMetadata for singleton lambda construct tree feat: set log retention of all CDK-vended custom resources with CustomResourceConfig Aug 9, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

comcalvi
comcalvi previously requested changes Aug 16, 2024
View reviewed changes
packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts Outdated Show resolved Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts Show resolved Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts Outdated Show resolved Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts Outdated Show resolved Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts Outdated Show resolved Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts Show resolved Hide resolved
@comcalvi
Copy link
Contributor

This is very close to merging 🙂 we're almost there!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2024
@mergify mergify bot dismissed comcalvi’s stale review August 16, 2024 17:59

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2024
comcalvi
comcalvi previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉

@mergify mergify bot dismissed comcalvi’s stale review August 16, 2024 20:07

Pull request has been modified.

comcalvi
comcalvi previously approved these changes Aug 16, 2024
View reviewed changes
@mergify mergify bot dismissed comcalvi’s stale review August 16, 2024 20:26

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 50125b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f2babd9 into aws:main Aug 16, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@comcalvi comcalvi comcalvi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@comcalvi comcalvi

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awslukeguan @comcalvi @aws-cdk-automation