-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(template): adding regression info in the bug template #31057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
b6d1d0b
to
ce7c874
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
59062b7
to
06e2496
Compare
06e2496
to
6b1c3b5
Compare
Co-authored-by: Grace Luo <54298030+gracelu0@users.noreply.github.com>
Co-authored-by: Grace Luo <54298030+gracelu0@users.noreply.github.com>
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes .
Reason for this change
Update bug template for users to inform about the code changes that resulted in breaking changes.
Description of changes
potential-regression
on the basis whether checkbox is selected in issue template or not.Description of how you validated changes
Validated template here
Label : potential-regression (will be created after approval)
Label will removed if this option is unchecked and added if this option is checked.
Verified with sample issue in personal repo here, can be tested on sample github issue created in personal repo.
Result will be seen in github actions.
Sample issue: shikha372#2
Sample run: https://github.com/shikha372/aws-cdk/actions/runs/10326894628/job/28591182838
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license