Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(template): adding regression info in the bug template #31057

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Aug 7, 2024

Issue # (if applicable)

Closes .

Reason for this change

Update bug template for users to inform about the code changes that resulted in breaking changes.

Description of changes

  • Adding checkbox to indicate whether this bug is a regression
  • Add option of an input for adding last known CDK version
  • Add GH workflow to run when an issue is opened or edit, workflow will add label potential-regression on the basis whether checkbox is selected in issue template or not.

Description of how you validated changes

Validated template here

Label : potential-regression (will be created after approval)
Label will removed if this option is unchecked and added if this option is checked.

Verified with sample issue in personal repo here, can be tested on sample github issue created in personal repo.
Result will be seen in github actions.

Sample issue: shikha372#2
Sample run: https://github.com/shikha372/aws-cdk/actions/runs/10326894628/job/28591182838

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 7, 2024 21:55
@github-actions github-actions bot added the p2 label Aug 7, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 changed the title adding regression info chore(document): adding regression info in the bug template Aug 7, 2024
@shikha372 shikha372 changed the title chore(document): adding regression info in the bug template chore(template): adding regression info in the bug template Aug 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 7, 2024 22:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 marked this pull request as ready for review August 8, 2024 18:15
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 8, 2024
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
shikha372 and others added 2 commits August 12, 2024 11:59
Co-authored-by: Grace Luo <54298030+gracelu0@users.noreply.github.com>
Co-authored-by: Grace Luo <54298030+gracelu0@users.noreply.github.com>
Copy link
Contributor

mergify bot commented Aug 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 12, 2024
Copy link
Contributor

mergify bot commented Aug 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cbb6605
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1f0ba96 into aws:main Aug 12, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Aug 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants