Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assertions): misformatted doc string causes generated docs to cutoff information #27392 #31199

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

stm29
Copy link
Contributor

@stm29 stm29 commented Aug 23, 2024

Issue #27392

Closes #27392

Reason for this change

Following Comment format,

* @param logicalId the name of the parameter. Provide `'*'` to match all parameters in the template.

creates this following format in .jsii assembly

              "docs": {
                "remarks": "Provide '*' to match all parameters in the template.",
                "summary": "the name of the parameter."
              },

Remarks section is created by jsii, when @remarks is mentioned or it takes anything after first paragraph. (after first dot)
Reference:
https://github.com/aws/jsii/blob/50e6c47fb873fab894e3779bafb0e84c31287839/packages/%40jsii/spec/src/assembly.ts#L313-L321

Decision on approach

  1. fix it from jsii / from our documentation portal side, by modifying configuration to show remarks also in portal.
  2. convert this detail as summary by keeping it in first paragraph. [This PR implements this]

Description of changes

Changed

@param logicalId the name of the parameter. Provide `'*'` to match all parameters in the template.

To, NOTE, . P --> , p

@param logicalId the name of the parameter, provide `'*'` to match all parameters in the template.

Description of how you validated changes

  1. $ npx lerna run build --scope=aws-cdk-lib --skip-nx-cache
  2. Ran build inside aws-cdk-lib --> username@aws-cdk-lib$ yarn build, this created .jsii file with compressed form.
  3. Now ran yarn jsii --> this uncompresses .jsii file and creates exact doc content inside .jsii file.
  4. Checked, everything is placed inside summary

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Aug 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 23, 2024 11:27
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@stm29
Copy link
Contributor Author

stm29 commented Aug 23, 2024

Exemption Request , as only doc string changes.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 23, 2024
@mrgrain mrgrain changed the title fix(assertions): misformatted doc string causes generated docs to cutoff information #27392 chore(assertions): misformatted doc string causes generated docs to cutoff information #27392 Aug 23, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 23, 2024 11:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Aug 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3079c70
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c629172 into aws:main Aug 23, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Aug 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
@stm29 stm29 deleted the issue_27392 branch August 23, 2024 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(assertions): misformatted doc string causes generated docs to cut off information
3 participants