-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vpcv2): implementation of add gateway method #31224
Merged
+4,568
−2,148
Merged
Changes from 47 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
31d3f48
Add RouteTable addRoute method
727b164
Update packages/@aws-cdk/aws-ec2-alpha/lib/route.ts
shikha372 cb8c941
Change CfnRoute to Route L2
d21be53
Update README.md
42830e7
Merge branch 'main' into vpcv2-rt-addroute
Leo10Gama 2f48ab2
Update integ test to use only one EIGW
f904a97
Add subnet associateRouteTable method
b52d498
Appease the linter
1aef528
Update subnet with public routeTable again
9b15a4b
Update subnet-v2.ts
shikha372 bc56a77
Update subnet-v2.ts
shikha372 cc8db35
Extend IRouteTable into IRouteTableV2
285da27
Merge branch 'main' into vpcv2-rt-addroute
shikha372 98f9d53
ok so route table v2 was not a great idea lol
b3e08c1
Merge branch 'main' into vpcv2-rt-addroute
Leo10Gama 1211fde
Update testing
ca9c385
Merge branch 'main' into vpcv2-rt-addroute
shikha372 eaa7ccb
add method associateRouteTable
shikha372 a25bb78
fixing route class
shikha372 1721026
making ipam props private
shikha372 bc393c2
successful build
shikha372 aed940f
adding validation for ipv4
shikha372 499c6c8
fixing egw route and subnet snapshot
shikha372 f296f3e
fixing readme and route unit test
shikha372 0002de5
fixing vpc snapshot
shikha372 909f7da
Update route snapshot
1b907c1
Update route snapshot
0dba8bb
Merge branch 'main' into vpcv2-rt-addroute
shikha372 8ca0a3c
adding EGW method to VPC
shikha372 f42666d
(feat): add EIGW implementation
shikha372 36a9511
adding unit and integ tests
shikha372 5bd279b
updating readme and snapshot for EGW
shikha372 6023ecd
Implement addNatGateway command
85eafa2
Test cleanup
09d3ae0
resolving conflicts
shikha372 c5f2b96
add vpn gateway v2
shikha372 5a05757
feat(vpcv2): add igw implementation
shikha372 391ae8e
fix validation for natGW
shikha372 aba5e66
add VPN route propogation to L2
shikha372 aeba62b
remove associate routetable
shikha372 2f1e60c
adding unit tests for internet gateway
shikha372 e060278
adding unit tests for VPN gateway
shikha372 74adb43
fixing all integ snapshots
shikha372 d136789
Merge branch 'main' into vpcv2-rt-addGateway
shikha372 5d63c6c
Apply suggestions from code review
shikha372 669c735
Apply suggestions from code review
shikha372 a9096f5
fix readme
shikha372 5c7548c
fixing nits for defining default
shikha372 4b4fb6b
Apply suggestions from code review
shikha372 dcb11e6
fix nits
shikha372 f30e1da
Merge branch 'main' into vpcv2-rt-addGateway
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my knowledge, what does these two lines do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is enforced from
awslint
to have the import methods in classes extendingResource
, since we haven't introduced it yet these are part of exceptions