Unit test for using escape hatch to scope down Key Policy #31246
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -167,8 +167,6 @@ export abstract class S3BucketOrigin extends cloudfront.OriginBase { | |||
|
|
|||
| /** | |||
| * Create a S3 Origin with Origin Access Identity (OAI) configured | |||
| * OAI is a legacy feature and we **strongly** recommend you to use OAC via `withOriginAccessControl()` | |||
There was a problem hiding this comment.
Is there a reason for removing this from the docstring?
There was a problem hiding this comment.
No. It was a fat finger mistake. Added back now. Thanks for catching it!
|
Comments on closed issues and PRs are hard for our team to see. |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Adding a unit test to make sure user is able to scope down the key policy to specific distribution ID via escape hatch.