-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add section to README on migrating from OAI to OAC #31247
Conversation
gracelu0
commented
Aug 29, 2024
- add section to README on migrating from OAI to OAC
- update sections in README for setting up OAI and OAC using imported buckets (user needs to manually update the bucket policy)
- update warnings to match the correct README section title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
* to the CloudFront distribution. | ||
* @default AccessLevel.READ | ||
*/ | ||
readonly originAccessLevels?: AccessLevel[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing because I realized this prop is not used and is defined in S3BucketOriginWithOACProps
(here) which makes sense because that's when we need to update the bucket policy.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Comments on closed issues and PRs are hard for our team to see. |