Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add README section for sse-kms circular dependency workaround #31262

Merged
merged 1 commit into from
Aug 30, 2024
Merged

add README section for sse-kms circular dependency workaround #31262

merged 1 commit into from
Aug 30, 2024

Conversation

gracelu0
Copy link
Contributor

  • add README section with steps for user to follow to use escape hatch to scope down the key policy

@gracelu0 gracelu0 requested a review from samson-keung August 30, 2024 01:01
@github-actions github-actions bot added the p2 label Aug 30, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2024 01:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 30, 2024
aws-cdk-automation
aws-cdk-automation requested changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

samson-keung
samson-keung approved these changes Aug 30, 2024
View reviewed changes
packages/aws-cdk-lib/aws-cloudfront-origins/lib/s3-bucket-origin.ts
@@ -156,7 +156,7 @@ export abstract class S3BucketOrigin extends cloudfront.OriginBase {
},
);
Annotations.of(key.node.scope!).addWarningV2('@aws-cdk/aws-cloudfront-origins:wildcardKeyPolicyForOac',
'To avoid circular dependency between the KMS key, Bucket, and Distribution,' +
'To avoid circular dependency between the KMS key, Bucket, and Distribution, ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@gracelu0 gracelu0 merged commit 54d597e into aws:gracelu0/s3-oac-l2 Aug 30, 2024
17 of 19 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

@samson-keung samson-keung samson-keung approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gracelu0 @aws-cdk-automation @samson-keung