Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime #31272

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime #31272

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
550b7b5
chore(synthetics): added syn-nodejs-puppeteer-9.0 as supported runtime
ashishdhingra Aug 30, 2024
6baf25b
Merge branch 'main' into user/ashdhin/add-syn-nodejs-puppeteer-9.0-ru…
HBobertz Sep 3, 2024
2481620
Merge branch 'main' into user/ashdhin/add-syn-nodejs-puppeteer-9.0-ru…
mergify[bot] Sep 4, 2024
efd12d4
Merge branch 'main' into user/ashdhin/add-syn-nodejs-puppeteer-9.0-ru…
kaizencc Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,19 @@ export class Runtime {
*/
public static readonly SYNTHETICS_NODEJS_PUPPETEER_8_0 = new Runtime('syn-nodejs-puppeteer-8.0', RuntimeFamily.NODEJS);

/**
* `syn-nodejs-puppeteer-9.0` includes the following:
* - Lambda runtime Node.js 20.x
* - Puppeteer-core version 22.12.1
* - Chromium version 126.0.6478.126
*
* New Features:
* - **Bug fixes** Bug fix to enable visual monitoring capabilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

* Bug fixes:
* - **Bug fix**: Enable visual monitoring capabilities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msambol Thanks for the review. I copied the content from https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-9.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I'm just saying it shouldn't be under New Features:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine -- its a little weird but we've already established a pattern of bug fixes being listed as a bullet under new features.

*
* @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-9.0
*/
public static readonly SYNTHETICS_NODEJS_PUPPETEER_9_0 = new Runtime('syn-nodejs-puppeteer-9.0', RuntimeFamily.NODEJS);

/**
* `syn-python-selenium-1.0` includes the following:
* - Lambda runtime Python 3.8
Expand Down
Loading