-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): enable grantDataApiAccess
method for imported database cluster
#31280
Open
go-to-k
wants to merge
6
commits into
aws:main
Choose a base branch
from
go-to-k:import-aurora-cluster-data-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,840
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
distinguished-contributor
[Pilot] contributed 50+ PRs to the CDK
label
Sep 1, 2024
github-actions
bot
added
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
labels
Sep 1, 2024
aws-cdk-automation
added
the
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
label
Sep 1, 2024
badmintoncryer
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I've added only a nit comment.
I hardcoded enableDataApi
as false
for the imported cluster, so I really appreciate the fix!
...-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-data-api-to-imported-cluster.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
Thanks, changed! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
and removed
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
labels
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue is a bug.
distinguished-contributor
[Pilot] contributed 50+ PRs to the CDK
effort/medium
Medium work item – several days of effort
p2
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31116 .
Reason for this change
It was not possible to call the
grantDataApiAccess
method for an imported database cluster.Because the imported database cluster always has the
enableDataApi
with false.https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/cluster.ts#L983
But the
grantDataApiAccess
throws an error when theenableDataApi
is set to false.https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/cluster.ts#L523-L526
Description of changes
Added the property
dataApiEnabled
to attributes for the imported database cluster.If the
dataApiEnabled
to the attributes is set to true, theenableDataApi
in the imported cluster will be set to true and thegrantDataApiAccess
can be called.Description of how you validated changes
Unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license