Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing notices integ test #31625

Merged
merged 2 commits into from
Oct 2, 2024
Merged

chore: fix failing notices integ test #31625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e4f08
mid work
iliapolo Oct 2, 2024
e65f6be
Merge branch 'main' into epolon/fix-notices-integ
mergify[bot] Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 5 additions & 44 deletions packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2339,55 +2339,19 @@ integTest(
}),
);

integTest('cdk notices are displayed correctly', withDefaultFixture(async (fixture) => {
integTest('cdk bootstrap notice is displayed correctly', withDefaultFixture(async (fixture) => {

const cache = {
expiration: 4125963264000, // year 2100 so we never overwrite the cache
notices: [
{
title: 'CLI Notice',
issueNumber: 1111,
overview: 'Overview for CLI Notice',
components: [
{
name: 'cli',
version: '<99.0.0',
},
],
schemaVersion: '1',
},
{
title: 'Framework Notice',
issueNumber: 2222,
overview: 'Overview for Framework Notice',
components: [
{
name: 'framework',
version: '<99.0.0',
},
],
schemaVersion: '1',
},
{
title: 'Queue Notice',
issueNumber: 3333,
overview: 'Overview for Queue Notice',
components: [
{
name: 'aws-cdk-lib.aws_sqs.Queue',
version: '<99.0.0',
},
],
schemaVersion: '1',
},
{
title: 'Bootstrap 22 Notice',
title: 'Bootstrap 1999 Notice',
issueNumber: 4444,
overview: 'Overview for Bootstrap 22 Notice. AffectedEnvironments:<{resolve:ENVIRONMENTS}>',
overview: 'Overview for Bootstrap 1999 Notice. AffectedEnvironments:<{resolve:ENVIRONMENTS}>',
components: [
{
name: 'bootstrap',
version: '22',
version: '<1999', // so we include all possible environments
},
],
schemaVersion: '1',
Expand All @@ -2406,10 +2370,7 @@ integTest('cdk notices are displayed correctly', withDefaultFixture(async (fixtu
},
});

expect(output).toContain('Overview for CLI Notice');
expect(output).toContain('Overview for Framework Notice');
expect(output).toContain('Overview for Queue Notice');
expect(output).toContain('Overview for Bootstrap 22 Notice');
expect(output).toContain('Overview for Bootstrap 1999 Notice');

// assert dynamic environments are resolved
expect(output).toContain(`AffectedEnvironments:<aws://${await fixture.aws.account()}/${fixture.aws.region}>`);
Expand Down
Loading