-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): cdk diff
on large templates fails when passing in toolkitStackName
and qualifier
#31636
fix(core): cdk diff
on large templates fails when passing in toolkitStackName
and qualifier
#31636
Conversation
Signed-off-by: Sumu <sumughan@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…ier' of https://github.com/aws/aws-cdk into sumughan/fix/diff-with-custom-bootstrap-name-and-qualifier
cdk diff
on large templates fails when passing in toolkitStackName
and qualifier
… integ test to succeed Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Closes #29179
Reason for this change
If your account is bootstrapped with a custom
toolkitStackName
orqualifier
, then runningcdk diff
does not work for large diff templates of over 50 KiB in size.Description of changes
The
toolkitStackName
was not passed down all the way through thecdk diff
code path - this PR fixes the issue by adding the optionaltoolkitStackName
property to theDiffOptions
interface incdk-toolkit.ts
and passing that value all the way through the diff code path to theuploadBodyParameterAndCreateChangeSet
function incloudformation.ts
, where the template asset is built and published.Description of how you validated changes
I created a CDK app locally and ran the commands (exactly following the reproduction steps from the original issue) using the CLI build from this PR and was able to successfully run
cdk diff
without needing to pass in the--toolkit-stack-name
flag.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license