-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iam): override Role.applyRemovalPolicy for customizeRoles #31652
fix(iam): override Role.applyRemovalPolicy for customizeRoles #31652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request I've run integ tests in aws-iam, but no changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice fix!
@konokenj thanks for raising the PR. I think the changes look good, but I would still like to request to update an existing/add a new integration under |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
I added integration tests while referring to this. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31651
Reason for this change
Role.customizeRoles
throws an Error if there is a construct that callsapplyRemovalPolicy
internally. This means users cannot use with some constructs likeRestApi
.This can be reproduced with:
Or explicitly:
Description of changes
While it might be possible to fix
RestApi
, there could be other constructs within aws-cdk-lib that also callRole.applyRemovalPolicy
. Moreover, it's nearly impossible to make library users aware of this.Since
Role
implements theIResource
interface, it has the responsibility to respond to theapplyRemovalPolicy
call. Therefore, I think it would be good to overrideapplyRemovalPolicy
in theRole
class.Description of how you validated changes
Fixed the existing unit test to change behavior.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license