feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814

mazyu36 · 2024-10-19T05:18:25Z

Issue # (if applicable)

Closes #31790.

Reason for this change

To support target group level cross-zone settings for ALB and NLB

Description of changes

Add crossZoneEnabled property to baseTargetGroup.

Description of how you validated changes

Add unit tests and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

vcschapp · 2024-10-21T17:19:50Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/alb/target-group.test.ts

@@ -805,4 +805,29 @@ describe('tests', () => {
    });
  });

+  // test cases for crossZoneEnabled
+  describe('crossZoneEnabled', () => {


Handle the undefined case also?

Added a test case.

vcschapp · 2024-10-21T17:19:55Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/nlb/target-group.test.ts

+
+  // test cases for crossZoneEnabled
+  describe('crossZoneEnabled', () => {
+    test.each([true, false])('crossZoneEnabled can be %s', (crossZoneEnabled) => {


Handle the undefined case also?

Added a test case.

Leo10Gama

Thanks for your contribution! Just a few small nit-picks from me, otherwise looks good!

Leo10Gama · 2024-11-08T22:07:43Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/alb/target-group.test.ts

+        TargetGroupAttributes: [
+          {
+            Key: 'stickiness.enabled',
+            Value: 'false',
+          },
+        ],


nit: Is this attribute always present for the ALB target group? This test could be clearer using Match.absent() like the NLB, but no worries if this can't be helped.

Thanks.
I've update the test to TargetGroupAttributes to be undefined by using Lambda Target Type.

packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md

Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

mazyu36 · 2024-11-13T09:26:43Z

@Mergifyio refresh

mergify · 2024-11-13T09:26:51Z

refresh

✅ Pull request refreshed

Leo10Gama

LGTM, thanks for the contribution!

codecov · 2024-11-13T17:43:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (588f1f6) to head (fd4cc78).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #31814      +/-   ##
==========================================
+ Coverage   77.29%   77.30%   +0.01%     
==========================================
  Files         114      114              
  Lines        7627     7627              
  Branches     1360     1360              
==========================================
+ Hits         5895     5896       +1     
+ Misses       1550     1549       -1     
  Partials      182      182

Flag	Coverage Δ
suite.unit	`77.30% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`77.30% <ø> (+0.01%)`	⬆️

mergify · 2024-11-13T17:43:37Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Leo10Gama · 2024-11-13T19:10:06Z

@Mergifyio update

mergify · 2024-11-13T19:10:15Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

Pull request has been modified.

aws-cdk-automation · 2024-11-14T03:49:47Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: fd4cc78
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

initial commit

6a6982e

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Oct 19, 2024

aws-cdk-automation requested a review from a team October 19, 2024 05:18

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Oct 19, 2024

aws-cdk-automation previously requested changes Oct 19, 2024

View reviewed changes

add README and integ tests

5592031

mazyu36 marked this pull request as ready for review October 19, 2024 07:20

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 19, 2024

vcschapp reviewed Oct 21, 2024

View reviewed changes

add test cases wgeb crossZoneEnabled is not specified

a71e5f5

github-actions bot mentioned this pull request Nov 1, 2024

Monthly PR metrics report #31972

Closed

badmintoncryer approved these changes Nov 2, 2024

View reviewed changes

Merge branch 'main' into target-group-crosszone

f0ca104

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 2, 2024

Leo10Gama self-assigned this Nov 8, 2024

Leo10Gama reviewed Nov 8, 2024

View reviewed changes

mazyu36 and others added 2 commits November 9, 2024 12:20

Update packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md

c2f6e83

Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

update unit test

c0bdc7a

mazyu36 requested a review from Leo10Gama November 9, 2024 03:26

mazyu36 added 2 commits November 9, 2024 12:27

Merge branch 'main' into target-group-crosszone

580ecbf

Merge branch 'main' into target-group-crosszone

56c242b

Merge branch 'main' into target-group-crosszone

4477239

Leo10Gama previously approved these changes Nov 13, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 13, 2024

Merge branch 'main' into target-group-crosszone

12cbdc9

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 13, 2024

Merge branch 'main' into target-group-crosszone

fd4cc78

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814

feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814

mazyu36 commented Oct 19, 2024

aws-cdk-automation left a comment

vcschapp Oct 21, 2024

mazyu36 Oct 22, 2024

vcschapp Oct 21, 2024

mazyu36 Oct 22, 2024

Leo10Gama left a comment

Leo10Gama Nov 8, 2024

mazyu36 Nov 9, 2024 •

edited

Loading

mazyu36 commented Nov 13, 2024

mergify bot commented Nov 13, 2024

Leo10Gama left a comment

codecov bot commented Nov 13, 2024 •

edited

Loading

mergify bot commented Nov 13, 2024

Leo10Gama commented Nov 13, 2024

mergify bot commented Nov 13, 2024

aws-cdk-automation commented Nov 14, 2024

feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814

Are you sure you want to change the base?

feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814

Conversation

mazyu36 commented Oct 19, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

vcschapp Oct 21, 2024

Choose a reason for hiding this comment

mazyu36 Oct 22, 2024

Choose a reason for hiding this comment

vcschapp Oct 21, 2024

Choose a reason for hiding this comment

mazyu36 Oct 22, 2024

Choose a reason for hiding this comment

Leo10Gama left a comment

Choose a reason for hiding this comment

Leo10Gama Nov 8, 2024

Choose a reason for hiding this comment

mazyu36 Nov 9, 2024 • edited Loading

Choose a reason for hiding this comment

mazyu36 commented Nov 13, 2024

mergify bot commented Nov 13, 2024

✅ Pull request refreshed

Leo10Gama left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 13, 2024 • edited Loading

Codecov Report

mergify bot commented Nov 13, 2024

Leo10Gama commented Nov 13, 2024

mergify bot commented Nov 13, 2024

❌ Mergify doesn't have permission to update

aws-cdk-automation commented Nov 14, 2024

AWS CodeBuild CI Report

mazyu36 Nov 9, 2024 •

edited

Loading

codecov bot commented Nov 13, 2024 •

edited

Loading