-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): garbage collect ecr assets (under --unstable flag) #31841
Merged
Merged
Changes from 4 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a17c682
refactor s3 gc into its own function
kaizencc 97a0fc0
grab repository name and get total images
kaizencc 7fdd0dd
get deletabes/taggables/untaggables
kaizencc 1865e9b
delete works too
kaizencc 34b1db0
refactor test suite
kaizencc 84329f0
unit tests and refactoring
kaizencc cde556d
finish unit test
kaizencc d82d349
3 integ tests working
kaizencc dc86f76
another test
kaizencc 5998025
Merge branch 'main' into conroy/ecrgc
kaizencc e90aa1a
readme updates
kaizencc 97fa8bf
Merge branch 'conroy/ecrgc' of https://github.com/aws/aws-cdk into co…
kaizencc 75c1d79
minor
kaizencc e45acdf
readme update
kaizencc 5163f4c
unique tags and ignore failures
kaizencc 6f61cc6
differet tags
kaizencc 494d189
Merge branch 'main' into conroy/ecrgc
kaizencc 7fe9336
proper tagging ecr
kaizencc 457e0ea
Merge branch 'conroy/ecrgc' of https://github.com/aws/aws-cdk into co…
kaizencc ae26d87
Merge branch 'main' into conroy/ecrgc
kaizencc 5bb09be
change up how image tags are created
kaizencc 0878e53
Merge branch 'main' into conroy/ecrgc
kaizencc d99ec7e
Merge branch 'conroy/ecrgc' of https://github.com/aws/aws-cdk into co…
kaizencc 2d565fb
Merge branch 'main' into conroy/ecrgc
kaizencc c930fb7
Merge branch 'main' into conroy/ecrgc
kaizencc ade9b4d
Merge branch 'main' into conroy/ecrgc
kaizencc 8e2d92d
merge issues
kaizencc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was wrong and was not used anywhere