Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): garbage collect ecr assets (under --unstable flag) #31841

Merged
merged 27 commits into from
Oct 26, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a17c682
refactor s3 gc into its own function
kaizencc Oct 21, 2024
97a0fc0
grab repository name and get total images
kaizencc Oct 21, 2024
7fdd0dd
get deletabes/taggables/untaggables
kaizencc Oct 21, 2024
1865e9b
delete works too
kaizencc Oct 21, 2024
34b1db0
refactor test suite
kaizencc Oct 22, 2024
84329f0
unit tests and refactoring
kaizencc Oct 22, 2024
cde556d
finish unit test
kaizencc Oct 22, 2024
d82d349
3 integ tests working
kaizencc Oct 22, 2024
dc86f76
another test
kaizencc Oct 22, 2024
5998025
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 22, 2024
e90aa1a
readme updates
kaizencc Oct 22, 2024
97fa8bf
Merge branch 'conroy/ecrgc' of https://github.com/aws/aws-cdk into co…
kaizencc Oct 22, 2024
75c1d79
minor
kaizencc Oct 22, 2024
e45acdf
readme update
kaizencc Oct 23, 2024
5163f4c
unique tags and ignore failures
kaizencc Oct 23, 2024
6f61cc6
differet tags
kaizencc Oct 23, 2024
494d189
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 23, 2024
7fe9336
proper tagging ecr
kaizencc Oct 23, 2024
457e0ea
Merge branch 'conroy/ecrgc' of https://github.com/aws/aws-cdk into co…
kaizencc Oct 23, 2024
ae26d87
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 23, 2024
5bb09be
change up how image tags are created
kaizencc Oct 24, 2024
0878e53
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 24, 2024
d99ec7e
Merge branch 'conroy/ecrgc' of https://github.com/aws/aws-cdk into co…
kaizencc Oct 24, 2024
2d565fb
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 24, 2024
c930fb7
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 25, 2024
ade9b4d
Merge branch 'main' into conroy/ecrgc
kaizencc Oct 25, 2024
8e2d92d
merge issues
kaizencc Oct 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/api/bootstrap/bootstrap-props.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Tag } from '../../cdk-toolkit';

export const BUCKET_NAME_OUTPUT = 'BucketName';
export const REPOSITORY_NAME_OUTPUT = 'RepositoryName';
export const REPOSITORY_NAME_OUTPUT = 'ImageRepositoryName';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was wrong and was not used anywhere

export const BUCKET_DOMAIN_NAME_OUTPUT = 'BucketDomainName';
export const BOOTSTRAP_VERSION_OUTPUT = 'BootstrapVersion';
export const BOOTSTRAP_VERSION_RESOURCE = 'CdkBootstrapVersion';
Expand Down
Loading
Loading